Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look up service accounts from informer before trying live lookup #71816

Merged
merged 1 commit into from Jan 1, 2019
Merged

Look up service accounts from informer before trying live lookup #71816

merged 1 commit into from Jan 1, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 6, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:

Makes the service account authenticator used informers to get pod/secret/serviceaccount data, and only fall back to live lookups if the data is not found in the informer

Which issue(s) this PR fixes:
Fixes #71811

Does this PR introduce a user-facing change?:

kube-apiserver: improves performance of requests made with service account token authentication

/cc @mikedanese

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2018
@liggitt
Copy link
Member Author

liggitt commented Dec 6, 2018

/sig auth

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 6, 2018
@liggitt liggitt mentioned this pull request Dec 6, 2018
Closed
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2018
@liggitt liggitt added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Dec 6, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 6, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Dec 6, 2018

/retest

@liggitt
Copy link
Member Author

liggitt commented Dec 26, 2018

/assign @mikedanese

@ash2k
Copy link
Member

ash2k commented Jan 1, 2019

This PR looks good to me, so I'm going to lgtm. I hope this is fine and I'm not "breaking" the review process in some way. Please let me know if I shouldn't have done it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2019
@ash2k
Copy link
Member

ash2k commented Jan 1, 2019

/retest pull-kubernetes-godeps

@ash2k
Copy link
Member

ash2k commented Jan 1, 2019

/test pull-kubernetes-godeps

@k8s-ci-robot k8s-ci-robot merged commit 6e182ed into kubernetes:master Jan 1, 2019
@liggitt liggitt deleted the service-account-lookup branch January 2, 2019 14:02
@liggitt liggitt mentioned this pull request Jan 7, 2019
Merged
@liggitt liggitt mentioned this pull request Oct 10, 2019
Closed
@mikedanese mikedanese mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krmayankk krmayankk krmayankk left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@ash2k ash2k

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api timeouts when using token authentication
5 participants
@liggitt @k8s-ci-robot @ash2k @krmayankk @mikedanese